-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid use of markdown syntax in classref #80109
Conversation
1. I checked it, I couldn't find any other matches for invalid use of Markdown. 👍 2. Some possible incorrect godot/doc/classes/@GlobalScope.xml Lines 365 to 366 in dcd187d
godot/doc/classes/@GlobalScope.xml Line 648 in dcd187d
Line 9 in dcd187d
godot/doc/classes/AudioEffectDelay.xml Lines 41 to 49 in dcd187d
3. This is more like material for another PR, but I noticed that some "strong" words ("not", "must") are sometimes in bold and sometimes in italics. italic "not" - 54 matches
italic "must" - 14 matches
|
The mathematical constant 𝑒 is usually italic. I think it should be
This is referring to the text on the menu button. I don't think it should be
Judging from the context, although related the function's name, it's just a stylized "Tap 2", or second tap. I think |
I think it's just capitalized because it's at a start of a sentence 🙃 Though the sentence itself is poorly phrased, IMO. I don't mind if we fix it, and if we replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes so far are good, but feel free to address brought up concerns.
Also: * changed `[b]true[/b]` to `[code]true[/code]` * use `[i]` for mathematical constant "e" * use `[b]` for button text & menu item text * improve markups about "tap1" and "tap2" in AudioEffectDelay
a71cbca
to
c4b5161
Compare
Added the following changes:
|
Thanks! |
Also changed
[b]true[/b]
to[code]true[/code]
.