Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undo methods for DELETE in EditorAutoloadSettings #79832

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix undo methods for DELETE in EditorAutoloadSettings #79832

merged 1 commit into from
Nov 9, 2023

Conversation

DarkMessiah
Copy link
Contributor

@DarkMessiah DarkMessiah commented Jul 23, 2023 •
edited by YuriSizov
Loading

Fixes errors:

  • core/object/undo_redo.cpp:334 - Error calling UndoRedo method operation 'set_persisting': 'ProjectSettings::set_persisting': Method not found
  • core/object/undo_redo.cpp:334 - Error calling UndoRedo method operation 'set_order': 'ProjectSettings::set_order': Method expected 0 arguments, but called with 0

Production edit: Fixes #82363

@Sauermann Sauermann added this to the 4.2 milestone Jul 23, 2023
@jsjtxietian jsjtxietian mentioned this pull request Sep 27, 2023
Closed
YuriSizov
YuriSizov approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like set_order has been like this since 3b7b581. So the bug is also present in Godot 3 and Godot 2.

Note for cherry-picking to 3.x: set_persisting seems to be missing in Godot 3.x as well, so this should be completely safe.

@YuriSizov YuriSizov added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Nov 9, 2023
@akien-mga akien-mga merged commit 75d27e3 into godotengine:master Nov 9, 2023
@akien-mga
Copy link
Member

Thanks!

@DarkMessiah DarkMessiah deleted the fix-autoload-settings branch November 9, 2023 18:07
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Error spam when undoing deleting a singleton in the editor
4 participants
@DarkMessiah @akien-mga @YuriSizov @Sauermann