Add missing word to text of the alert dialog

[WiseNoodle]

I hope I followed all the guidelines correctly.

• Bugsquad edit, fixes: Missing word in alert popup #79380

[AThousandShips]

You will need to squash your commits, see here

[WiseNoodle]

Reverting commits is confusing. If I didn't do It correctly close this and i'll redo it

[AThousandShips]

You will need to do git rebase -i master and then write "fixup" in front of the other commits

[WiseNoodle]

Like so? (forgive me I'm still learning git)

[AThousandShips]

No replace "pick" with "fixup" except for the first one

[AThousandShips]

so:

pick ... Added missing word ...
fixup ... removed self comment
fixup ... removed self comment
fixup ... Merged ...

[AThousandShips]

Then you need to do git push -f

[WiseNoodle]

I'm trying my best lol, I'm kinda lost rn; It says everything is up to date when i push

[WiseNoodle]

Oh boy, i have definitely messed something up

[AThousandShips]

You wrote "it" instead of "git"

[WiseNoodle]

this is painful for you to watch im sure, my apologies.

[Sauermann]

Don't worry, git has a bit of a learning curve. But it helps to learn the basics.

[AThousandShips]

Not at all, there was a time when I was getting used to it too

[WiseNoodle]

I have made a grave mistake. I ran a recursive delete on all files trying to remove all commits (followed error message suggestion?) so please discard this pull request and let me start fresh

[WiseNoodle]

(recloning, give me a few)

[WiseNoodle]

Okay, it finished downloading. I have a fresh slate. I just need to sync it with what we've done so far right?

[AThousandShips]

Yes you just pull this branch from your repository

[WiseNoodle]

Okay, I have now pulled that branch from my fork

[WiseNoodle]

HA got it!

[WiseNoodle]

now jes gotta change the text...

[WiseNoodle]

oh wait

[WiseNoodle]

it is XD

[WiseNoodle]

What's GitHub doing right now? Is it checking all os versions?? That's so cool

[AThousandShips]

It's running a lot of automated tests! Compiling it all and stuff, it's really cool

[WiseNoodle]

That's amazing, so is there anything else I need to do?

[AThousandShips]

Shouldn't be, the checks should pass, and I will give this a review

[WiseNoodle]

In hindsight, I should have compiled and run a test of it before comitting it... But it's just a sting of text, it should be fine if the dialog was made to scale with the text.

[AThousandShips]

In the future that's a great thing to do, to catch errors and things

[WiseNoodle]

Question: Does this change get applied in the next update (e.g. 4.1.1 or 4.2) or is it an instant bugfix?

[YuriSizov]

Question: Does this change get applied in the next update (e.g. 4.1.1 or 4.2)?

It will probably be included in both.

FYI, the email that you've used to author your commit is invalid (wisenoodle21@gmail, missing .com). Which means it will not be counted towards your personal contributions on GitHub. You should be able to fix that using git commit --amend --author="Your Name <your_correct_email>" and then force-pushing again. You should also change your local git settings to make sure this doesn't happen in future.

PS. Please use the "Edit" button on GitHub and avoid multiposting. Each message that you send creates a notification for a lot of people. If you need live assistance, consider joining contributors chat at https://chat.godotengine.org!

[AThousandShips]

You deleted the message, please update it to fit the PR title with git commit --amend

[YuriSizov]

Thanks! And congrats on your first merged Godot PR!

[AThousandShips]

Congratulations!

[WiseNoodle]

Thank you all so much for all your help, I hope to improve my git skills and continue to contribute in the future!

[YuriSizov]

Cherry-picked for 4.1.1.