Add hit_back_faces property to RayCast3D
#79330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That ASan CI failure looks to be related to #78749 and not caused by this PR. |
rburing
approved these changes
Jul 11, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
hit_back_facesparameter, found inPhysicsRayQueryParameters3D, as a property to theRayCast3Dnode.For reasons that are not obvious to me this query parameter was left out of the
RayCast3Dnode in #54857, which is causing some friction when using Godot Jolt, as Jolt's notion of back-faces include all shapes, including convex shapes, leading to users having to do their ray-casting manually, usingintersect_ray, when they run up against this discrepancy and want to disable this parameter.(The documentation was copied from the equivalent parameter in
PhysicsRayQueryParameters3D.)