Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Fix multithreaded scrollbar visibility update. #78833

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 29, 2023

Fixes #78434

I do not see any regressions, but issues like #77961 and #77558 can be hard to reproduce, so any extra testing is appreciated.

cc @bitsawer, @KoBeWi

@bruvzg bruvzg added this to the 4.1 milestone Jun 29, 2023
@bruvzg bruvzg requested a review from a team as a code owner June 29, 2023 12:44
@akien-mga
Copy link
Member

CC @groud @Sauermann for testing who seemed to be able to reproduce issues too.

@akien-mga
Copy link
Member

akien-mga commented Jun 29, 2023

Tested locally on Linux, I could reproduce #78434 before this PR and confirm that this fixes it.

Also tested the help section, didn't notice issues on big classes like ProjectSettings and EditorSettings.

@akien-mga akien-mga merged commit 4642448 into godotengine:master Jun 29, 2023
@akien-mga
Copy link
Member

Thanks!

@bitsawer
Copy link
Member

Looks like this was already merged, but I can confirm this fixes the issue both on the MRP test project and with my real project.

@Sauermann
Copy link
Contributor

Thanks for resolving this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor Output window regression, RichTextLabel does not always update its scrollbar properly
4 participants