Add a get_partial_path method to NodePath
#78638
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlupugla
reviewed
Sep 17, 2023
|
|
||
| NodePath::NodePath(const Vector<StringName> &p_path, bool p_absolute) { | ||
| if (p_path.size() == 0) { | ||
| if (p_path.size() == 0 && !p_absolute) { |
There was a problem hiding this comment.
What is the reason for this change and the similar one below? Do I need to include a similar change when making the slice method?
There was a problem hiding this comment.
The problem was an edge case where p_absolute was being ignored if the path was empty.
|
Superseded by #81822 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements this proposal and closes godotengine/godot-proposals#7148
This PR adds a
get_partial_pathmethod to NodePath for getting the first X parts of a path. Discussion: Would it be worth specifying the start index too, or getting the last parts of a path? I only need the first parts for my uses.I added some test cases to ensure the behavior is correct, and I ran into a minor bug where the internal constructors with the StringName arrays will discard the absolute flag if the path is empty. So I added a check to continue with the construction whenever absolute is set to true (return only when absolute is set to false).