Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change light themes default contrast from -0.08 to -0.06 #78297

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

aganm
Copy link
Contributor

@aganm aganm commented Jun 15, 2023

I'm a light theme user and I felt like something was wrong with the light themes in godot. The issue was the negative contrast being a little bit too low, -0.08 overblows the highlights far too much. A small correction to -0.06 looks much better!

To save the time of other light theme users, I think it's a good idea to make that fix so that light themes look correct by default.

-0.08 overblows the highlights, -0.06 looks much better.
@Calinou
Copy link
Member

Calinou commented Jun 15, 2023

Can you take screenshots to compare before/after in the editor?

@aganm
Copy link
Contributor Author

aganm commented Jun 16, 2023

For solarized light,

Here's a screenshot before (-0.08):

image

Screenshot after (-0.06):

image

@aganm
Copy link
Contributor Author

aganm commented Jun 16, 2023

For the regular Light, it's a more subtle difference, but still an improvement:

Screenshot before (-0.08):

image

Screenshot after (-0.06):

image

@aganm
Copy link
Contributor Author

aganm commented Jun 16, 2023

Oh, hmm.. I just noticed something. The light themes in godot 4 seem broken beyond what I initially thought.

At first, I only noticed the overblown highlights. But I went back to compare with godot 3 and the light themes in godot 3 are correct.

See the solarized light theme in godot 3 (default settings):

image

And in godot 4, the colors are overblown and the minimap has no highlight (default settings):

image

This PR somewhat fixes the overblown colors in godot 4, but the minimap highlight is still missing.

I double checked different godot 4 versions and the issue is present in all these versions:
4.0
4.1 beta 1
4.1 beta 2

@aganm
Copy link
Contributor Author

aganm commented Jun 16, 2023

Should I close this PR and open an issue instead?

@Calinou
Copy link
Member

Calinou commented Jun 16, 2023

Should I close this PR and open an issue instead?

I think you can keep this PR open, but please open an issue for the minimap theming regression.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Jul 10, 2023
@akien-mga akien-mga merged commit d3b69c0 into godotengine:master Aug 17, 2023
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@aganm aganm deleted the contrast branch April 3, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants