Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to show icon in Android TV and run app as Android launcher #78164

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

0xafbf
Copy link
Contributor

@0xafbf 0xafbf commented Jun 13, 2023

For some reason AndroidManifest.xml files are not being used when building an app for Android. There are multiple reasons to add things to that file, but even though there are some places that tell the files are merged, it seems that it is always generated.

The reasons I had to modify this file are:

  • Add the intent category LEANBACK_LAUNCHER so it adds an icon to Android TV launchers.
  • Add the intent categories HOME and DEFAULT so a godot app can be used as a launcher itself (useful for kiosk experiences).

What I did in the end was to add these as export options, so the AndroidManifest generator adds these when the specific options are selected in the Export window.

Fixes part of #76963
Edit: doesn't actually fix that issue, as the AndroidManifest.xml problem persists. but it fixes the problem that the issue OP had.

@0xafbf 0xafbf requested a review from a team as a code owner June 13, 2023 02:14
@0xafbf 0xafbf force-pushed the allow-export-tv-and-launcher branch from 256eb5f to ba652c7 Compare June 13, 2023 02:31
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@m4gr3d m4gr3d modified the milestones: 4.x, 4.2 Jun 18, 2023
@YuriSizov YuriSizov merged commit 70b5330 into godotengine:master Jul 14, 2023
@YuriSizov
Copy link
Contributor

Thanks! Based on the discussion in the issue, it should remain open until a more general problem is addressed.

@0xafbf 0xafbf deleted the allow-export-tv-and-launcher branch July 18, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants