Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use S, V in hue bar of ColorPicker #78100

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Use S, V in hue bar of ColorPicker #78100

merged 1 commit into from
Jul 12, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jun 10, 2023

Same as #60561

@KoBeWi KoBeWi added this to the 4.x milestone Jun 10, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner June 10, 2023 23:40
@fire fire requested a review from a team June 13, 2023 05:43
fire
fire approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea but I didn't technically test it.

@Calinou mentioned liking it too.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Jun 13, 2023
Calinou
Calinou approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased against latest master), it works:

image

@YuriSizov YuriSizov merged commit 5058831 into godotengine:master Jul 12, 2023
@KoBeWi KoBeWi deleted the commit_necromancy branch July 12, 2023 15:28
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@KoBeWi @YuriSizov @fire @Calinou @akien-mga