Ensure that _drop_physics_mouseover only happens when necessary
#78078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the call was executed every time, because in the `_drop_mouse_over();` a few lines above, `gui.mouse_over = nullptr;` was set.
RandomShaper
approved these changes
Jun 12, 2023
|
My estimation is, that the current code is not noticeable bad. |
akien-mga
added
the
cherrypick:4.1
YuriSizov
changed the title
_drop_physics_mouseover only happens when necessary_drop_physics_mouseover only happens when necessary
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the call was executed every time, because in the
_drop_mouse_over();a few lines above,gui.mouse_over = nullptr;was set. With this change, it gets executed only the first time, the mouse is moved to a Control.I have noticed this while investigating coverage-tests for Viewport.