Add a way to invalidate preview cache #77697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new tooltips for textures and audio streams rely on preview metadata. But for previews generated before the metadata was added it will be empty, so the tooltips will display 0x0 dimensions or 0 length. It will display as that until the resource is modified (i.e. its hash changes).
This PR adds a mechanism to force refreshing the previews, so that correct metadata is loaded. Preview cache gets a new field:
version. To invalidate previews we just need to increase the current version. Note that it forces all exiting previews to be generated again, which is rather costly in terms of I/O in big projects. Also some previews seem to be generated only on demand, so their tooltips are invalid and print an error when displayed for the first time.