ResourceLoader: Use ThreadLoadTask.thread as the check for "real" threads #74108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I don't think we are in time to include this in the next release, which I think will be 4.0-stable. I'll let @akien-mga decide the milestone. |
|
For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
|
Thanks @akien-mga ! Added my work email to the github account and all is well. That has been wrong for a few years now 😆 |
|
Superseded by #74405. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before PR #73647 using the
ThreadLoadTask.semaphoreas the check for "real" threads was OK, since only "real" threaded tasks also had a semaphore. After that PR that is no longer the case, since also Tasks that were created byResourceLoader.load()can get acond_var(formerlysemaphore). So this PR usesThreadLoadTask.threadas a check for "real" threads instead.Only "real" threaded tasks should change
thread_waiting_count,thread_loading_count,thread_suspended_countandthread_load_semaphore. So all the places where these are changed/used get the check forThreadLoadTask.thread.