-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve editor state persistence #72277
Improve editor state persistence #72277
Conversation
543f5c0
to
c6d3ba5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strangely I couldn't find any GH issues on this topic
The ShaderEditor
is tracked by #29094. Though, that would include caching the full sate i.e bookmarks, carets etc that the ScriptEditor
currently does.
c6d3ba5
to
6bd1b8d
Compare
5e3c6d8
to
8d9cc24
Compare
Updated the PR with the following changes.
|
8d9cc24
to
7bc88b4
Compare
It would be great if the FileSystem panel could preserve expanded folders. |
7bc88b4
to
5e33dcd
Compare
Rebased and updated:
|
5e33dcd
to
111b54c
Compare
|
There's one more bug with filesystem dock. It stores EDIT: |
064d09d
to
d626d00
Compare
Okay, rewrote a few things.
In addition, I introduced (As an alternative approach, we could add two parameters (default: false) to |
d626d00
to
33ea232
Compare
Needs rebase 🙃 |
33ea232
to
d3a7e49
Compare
This comment was marked as resolved.
This comment was marked as resolved.
d3a7e49
to
8514ced
Compare
Floating docks should now be restored correctly again, somehow a small code section got automatically removed during the rebase. Addressed all other review comments too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one last documentation comment left, but other than that I think it's fine now.
8514ced
to
dc46163
Compare
Thanks! |
This PR is an attempt to improve the editor state preservation when restarting the editor. Strangely I couldn't find any GH issues on this topic, but I know this has been a inconvenience for quite a few users, myself included :)
The following settings are now correctly saved and loaded:
Additional misc changes (internal, not compat-breaking):
"use_orthogonal"
to"orthogonal"
VIEW_DISPLAY_SHADELESS
toVIEW_DISPLAY_UNSHADED
While this PR should fix the most annoying cases where the layout/settings would be lost, there are almost certainly still some left. Please let me know if you find one that should be included in this PR :)
Somewhat related side note: I realized that after 4.0 is out we need to do some significant internal refactoring of some core editor classes/files (e.g. editor_node/node_3d_editor_plugin). There's lots of duplicated/legacy code, confusing/short variable names, etc. which make it very hard to maintain them.
And lastly, since some visual comparisons won't do any harm:
Editor before and after the restart with this PR

Editor after restart with beta 16 (manually switched from scene "2d_test" to "main_test")

Bugsquad edit: Closes godotengine/godot-proposals#4789