Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement export_multiline support for Array[String] and Dictionary #70540

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

vaartis
Copy link
Contributor

@vaartis vaartis commented Dec 24, 2022

For arrays, specifically check if it's a string array and pass the type on to the editor. For dictionaries, save the hint on the type and use it later to draw the multiline editor, except for when adding a string key, because that doesn't make much sense. All string values however will be drawn as multiline.

Closes #62011

For arrays, specifically check if it's a string array and pass the
type on to the editor. For dictionaries, save the hint on the type and
use it later to draw the multiline editor, except for when adding a
string key, because that doesn't make much sense. All string values
however will be drawn as multiline.
@vaartis vaartis requested a review from a team as a code owner December 24, 2022 22:49
@Calinou Calinou added this to the 4.0 milestone Dec 24, 2022
Copy link
Member

@vnen vnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GDScript changes are good. I can't tell much about the editor part.

@akien-mga akien-mga merged commit 4c2dea1 into godotengine:master Jan 13, 2023
@akien-mga
Copy link
Member

akien-mga commented Jan 13, 2023

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GDScript 2.0: Multiline string arrays aren't supported anymore
4 participants