Minor code cleanup in xr_nodes
#70240
Open
+118
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reference parameters * Add const where possible * Remove semicolon at the end of some method implementation * `vp_he` -> `viewport_half_extents` * Simplify some if else logic * Remove some useless break * Remove already explicit comments "get our XRServer" Signed-off-by: Quentin Guidée <quentin.guidee@gmail.com>
quentinguidee
force-pushed
the
refactoring/xr-nodes
branch
from
8061dfd
to
48f40f2
Compare
| } | ||
|
|
||
| void XRNode3D::trigger_haptic_pulse(const String &p_action_name, double p_frequency, double p_amplitude, double p_duration_sec, double p_delay_sec) { | ||
| void XRNode3D::trigger_haptic_pulse(const String &p_action_name, double p_frequency, double p_amplitude, double p_duration_sec, double p_delay_sec) const { |
There was a problem hiding this comment.
Not entirely sure if it makes sense to make this const. Haptics do change internal state even if this is offloaded to the XR interface, unless it's trigger_haptic_pulse is also const (which it shouldn't be)
|
I'm not against these changes, some are nice cleanups others are just semantics. Especially passing some of the parameters as references is probably a good idea. |
|
Needs a rebase as well as addressing the review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean xr_nodes
vp_he->viewport_half_extents