Replace Cubic to CubicInTime in the animation track interpolation type
#64879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
cubic-to-cubicintime
branch
from
ff95946 to
d96cc74
Compare
akien-mga
reviewed
Aug 26, 2022
| @@ -600,9 +600,6 @@ | |||
| <constant name="INTERPOLATION_CUBIC" value="2" enum="InterpolationType"> | |||
| Cubic interpolation. | |||
There was a problem hiding this comment.
Maybe this should mention it's with uniform time now?
There was a problem hiding this comment.
I think fixed times cubic interpolation is a more special case. In timelines, time is generally taken into account, so there is no need to mentions that it is unifrom time.
akien-mga
approved these changes
Aug 26, 2022
reduz
approved these changes
Aug 26, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #63602. I discussed this with @reduz in contributors chat. The old Cubic interpolation is probably not used by anyone in Animation, so it will be replaced by CubicInTime. However, the old Cubic interpolation still continue to be used in Curve and Gradation since it is low calc cost.