Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace meta properties with regular properties in Control #64626

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

YuriSizov
Copy link
Contributor

@YuriSizov YuriSizov commented Aug 19, 2022

Fixes #61343. Supersedes #61529.

As discussed with @reduz, meta in this case is likely not needed and normal properties should be used. The logic should be overwise unchanged, including ignoring the stored value if it doesn't match the state of the control (e.g. it doesn't matter if the layout mode is stored as "anchors" if it's a child of a container, we just ignore it).

The property is now saved more often, but it shouldn't be a huge bother, as it is a property of the node after all, even if it's not relevant for the runtime.


I'll have to rebase this soon to update for the changes in property revert methods from #64334. But as far as this PR is concerned, this is a cosmetic change. Though some builds will fail, because I didn't update the documentation for temporarily bound methods. They'll soon be gone, so there is no point in doing that. Done

@YuriSizov YuriSizov added this to the 4.0 milestone Aug 19, 2022
@YuriSizov YuriSizov requested a review from KoBeWi August 19, 2022 15:47
@YuriSizov YuriSizov requested a review from a team as a code owner August 19, 2022 15:47
@YuriSizov YuriSizov force-pushed the control-farewell-meta branch from b4aaae8 to e08feee Compare August 19, 2022 17:53
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property is now saved more often, but it shouldn't be a huge bother, as it is a property of the node after all

Being a regular property doesn't really make it less bothersome than a meta 🙃

We could maybe look into handling properties that don't need to be saved (like offsets inside a container etc.), but it's not important for now.

@akien-mga akien-mga merged commit acd8fb7 into godotengine:master Aug 22, 2022
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov deleted the control-farewell-meta branch August 22, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragging Control nodes is super slow
3 participants