Reorganize code of control.cpp for better maintainability
#63318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jul 26, 2022
YuriSizov
force-pushed
the
control-code-reorg
branch
from
fe0a8d0
to
01a8bff
Compare
YuriSizov
force-pushed
the
control-code-reorg
branch
from
01a8bff
to
6ca9500
Compare
|
Thanks! |
This was referenced Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to do this for a very long time. Existing code in
control.cppis a big mess with methods sometimes ending up in completely random places. Yes, this PR would make it harder to navigate the history of this core file, but working with it as it stands makes Jack a very dull boy.This change has no functional difference, it's just a reorder of things. I've only renamed
_override_changedto_theme_property_override_changedto make its purpose clear. It's an internal method, so it doesn't affect anything. There are some other things that could be renamed, but they have an effect way outside of this class, so I didn't touch it here.