-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a floating-point number for the timeout
property in HTTPRequest
#60402
Conversation
be19eca
to
551a0a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggestions to avoid CMP_EPSILON
for readability.
This allows for greater precision when specifying a timeout in HTTPRequest in `3.x`, similar to what is already possible in `master`.
551a0a2
to
069c955
Compare
A was about to merge this, but isn't this a script-breaking change? func some_func():
var timeout : int = $HTTPRequest.timeout I guess it's a rare instance, but it's worth mentioning maybe? |
In GDScript, it seems to be happy to do implicit conversion:
But that would likely be more breaking for C# and GDNative indeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion, we found that the slight compat breakage is ok for 3.5 and it will be pointed out in the # Changed
section of the changelog, together with a few other theoretically API breaking changes done in 3.5 (like the new Navigation API).
Thanks! |
This allows for greater precision when specifying a timeout in HTTPRequest in
3.x
, similar to what is already possible inmaster
.This also improves the documentation (which could also be added to
master
).See godotengine/godot-proposals#4419.