Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't abort loading scene on missing dependency #58554

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Feb 26, 2022

Fixes #54603

reduz
reduz previously approved these changes Feb 28, 2022
@reduz reduz dismissed their stale review February 28, 2022 09:02

Missing error report

reduz
reduz previously requested changes Feb 28, 2022
Copy link
Member

@reduz reduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but don't forget to report the missing resource dependencies via:
ResourceLoader::notify_dependency_error(..)
you can check in the binary format (resource_format_binary.cpp) how this is done.

@KoBeWi
Copy link
Member Author

KoBeWi commented Feb 28, 2022

There is a dependency error already though. It's the same as in binary, but condition order is different.

@reduz reduz dismissed their stale review February 28, 2022 13:18

I misread the code

@reduz
Copy link
Member

reduz commented Feb 28, 2022

Its good

@akien-mga akien-mga merged commit 54a777b into godotengine:master Feb 28, 2022
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the MIA branch February 28, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open scene with broken dependency on ext_resource
3 participants