Rename free mode to floating mode #57103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriceci
force-pushed
the
rename-free-mode-floating
branch
3 times, most recently
from
b1bf89a to
6fef5ad
Compare
akien-mga
reviewed
Jan 24, 2022
akien-mga
approved these changes
Jan 24, 2022
fabriceci
force-pushed
the
rename-free-mode-floating
branch
2 times, most recently
from
3dee874 to
66b72ad
Compare
|
@akien-mga For the android builds, is this a cache issue? |
|
Looks like it yeah :| It's pretty difficult to fix as GitHub Actions don't provide an easy way to invalidate a corrupted cache. I'll figure something out. |
|
You could try to rebase and force push. It looks like a more recent PR doesn't have a broken cache for Android: https://github.com/godotengine/godot/runs/4922801853?check_suite_focus=true Rebasing should force the PR to get a cache from the latest |
fabriceci
force-pushed
the
rename-free-mode-floating
branch
from
66b72ad to
856142a
Compare
|
Didn't work... but let's see if the merge commit would pass CI when merging. Otherwise the only option is to change the cache key in the workflow configuration and invalidate CI for all PRs :| (+ pollute git diff with CI related config tweaks) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, to be more explicit.
Edit: I also remove the property group for Floating Mode in 2D that contained wall_min_slide_angle.
Unlike in 3D, in 2D, this property is only used for the floating mode. Even is a group was was clearer, I think consistency between 2-3D is better (as a group implies changing the property name).