Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document get_minimum_size not called in some nodes #55935

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Document get_minimum_size not called in some nodes #55935

merged 1 commit into from
Dec 15, 2021

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 14, 2021

Closes #35909
Supersedes #35923

@KoBeWi KoBeWi added enhancement documentation cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:gui labels Dec 14, 2021
@KoBeWi KoBeWi added this to the 4.0 milestone Dec 14, 2021
@KoBeWi KoBeWi requested a review from a team as a code owner December 14, 2021 16:49
@mhilbrunner mhilbrunner merged commit e8e2865 into godotengine:master Dec 15, 2021
@mhilbrunner
Copy link
Member

Thanks!

@mhilbrunner mhilbrunner mentioned this pull request Dec 15, 2021
Closed
@KoBeWi KoBeWi deleted the get_minimum_size_not branch December 15, 2021 02:59
@akien-mga
Copy link
Member

akien-mga commented Dec 21, 2021 •
edited
Loading

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

_get_minimum_size() is not called for non-abstract containers
3 participants
@KoBeWi @mhilbrunner @akien-mga