-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the smart word wrap property to preview label in batch rename dialog #52690
Added the smart word wrap property to preview label in batch rename dialog #52690
Conversation
The mentioned bug is fixed but this raises another problem that the height of the label does not shrink after the label is resized (when each new line is added). Demo of the new issue: batch-rename-new-glitch.mp4 |
This bug already exists in master. You can check the same by just toggling the advanced options, it does not resize correctly. |
Here's how it looks on current master: batch_rename2.mp4The original issue (text getting out of the window) isn't there. It's only on 3.x branch. Maybe make a separate PR for 3.x to fix size not updating and another one for master to set the autowrap (or just use this PR for that, just changing the title). |
I have found the reason of the bug in master but currently can't find a way to fix it. But after that PR, dialogs are now implemented using |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Cherry-picked for 3.5. |
Cherry-picked for 3.4.3. |
closes #52074
batch-rename.mp4