Remove packed scene gltf. #52531
Merged
Remove packed scene gltf. #52531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
force-pushed
the
remove-gltf-packed-scene
branch
7 times, most recently
from
8d128ec to
2c5893d
Compare
fire
force-pushed
the
remove-gltf-packed-scene
branch
2 times, most recently
from
0551b6a to
b30b4aa
Compare
reduz
approved these changes
Sep 10, 2021
|
Docs need to be updated, otherwise looks good. |
We determined through discussion that composing the packed scene from a node tree was a better design because it removed duplication of code.
fire
force-pushed
the
remove-gltf-packed-scene
branch
from
b30b4aa to
523b2d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted as part of #52501.
Part of godotengine/godot-proposals#3273