-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad popups offset in editor with single window off #52280
Fix bad popups offset in editor with single window off #52280
Conversation
This won't work if the control is rotated or scaled. It's not a problem in the editor, but e.g. TextEdit can't use this. The problem might lie in |
89d9c6d
to
9a0f422
Compare
@KoBeWi All buggy popup were using I've modified the PR to replace these occurence. |
This PR looks quite similar to #37506, but I am not sure that on e is still being worked on. You might want to have a look to it. |
@groud All cases fixed by this PR are also fixed in #37506 with the same modifications and #37506 is more exhaustive. I think we could close this one and "reactivate" the review process of #37506. |
@jmb462 If you are up for it, it would likely be preferable if you were to incorporate the changes from the other PR here, add that other contributor as co-author and see it through to the end. The other PR is a year old, they may not be ready to work on it right now. But you are here 🙃 |
9a0f422
to
19de8f9
Compare
OK, I've included most of @giarve modification in this PR (from #37506). BUT I didn't include @giarve modification for following files cause it wasn't clear to me :
|
8310e08
to
414b844
Compare
414b844
to
b4f551f
Compare
b4f551f
to
7d3e8f8
Compare
Needs rebase, also |
7d3e8f8
to
1ee7ed2
Compare
@KoBeWi Done. Seems finished to me. |
Does it fix to #50720? I guess that issue caused by same reason. |
No. It only deals with popups. |
So I accidentally opened an extremely similar PR 3 days ago, which has most of the changes that this one has. I made sure to go over every single popup, so you can take a look if your PR isn't missing something I did. I know that at least my changes to |
1ee7ed2
to
e6752dd
Compare
Done. I've completed this PR with some of your changes that were missing here. |
e6752dd
to
5306401
Compare
I just created a new conflict by merging another PR, so needs a rebase. |
Co-authored-by: Gil Arasa Verge <gilarasaverge@gmail.com> Co-authored-by: Tomasz Chabora <kobewi4e@gmail.com>
5306401
to
81efebb
Compare
I did it myself and force pushed the rebase so that we can get it merged. |
For the record there's a few more places with
|
These are unrelated. The PR was only about popups. |
Thanks! |
Fix #47217
Issue description
When single window is disabled, popup menus in editor pops at a bad offset (see GIFs below)
Fix proposal (Updated after Kobewi comment)
Using
get_screen_transform()
instead ofget_global_transform()
to set the popup position to deal with offset in multiwindow mode correctly.BEFORE
Bezier Editor bug
Script Editor bug
Shader Editor Bug
Curve editor bug
Canvas editor bug
AFTER
Bezier editor fixed
Script editor fixed
Shader Editor Fixed
Curve Editor Fixed
Canvas Editor Fixed