Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GraphEdit connections consistent on zoom #51975

Merged
merged 1 commit into from
Aug 22, 2021
Merged

Make GraphEdit connections consistent on zoom #51975

merged 1 commit into from
Aug 22, 2021

Conversation

Jummit
Copy link
Contributor

@Jummit Jummit commented Aug 22, 2021

Previously the connections would change shape depending on how far was zoomed in, which was particullary obvious after #51952.

Before:

before.mp4

After:

after.mp4

@Jummit Jummit requested a review from a team as a code owner August 22, 2021 09:43
@YuriSizov YuriSizov added this to the 4.0 milestone Aug 22, 2021
fire
fire approved these changes Aug 22, 2021
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good from a design standpoint.

@fire fire merged commit 51ec46e into godotengine:master Aug 22, 2021
@Jummit Jummit deleted the consistent-graphedit-connections branch August 22, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Jummit @fire @YuriSizov