-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Rationalize property reversion #51166
Conversation
58b7f3d
to
581eb8f
Compare
In the cherry-picked commit from 4.0, I've replaced the cases of |
This needs to be implemented in this PR to be mergeable IMO. We used |
581eb8f
to
0b94f5f
Compare
I was about to comment this but the diff changed and it seems I haven't tested this code nor whether this PR breaks anything for C#, but this is probably how bool CSharpScript::inherits_script(const Ref<Script> &p_script) const {
if (!script_class)
return false;
Ref<CSharpScript> cs_script = p_script;
if (cs_script.is_null())
return false;
if (!cs_script->script_class)
return false;
return cs_script->script_class->is_assignable_from(script_class);
} |
@neikeq, it changed indeed. I was in the middle of writing this comment. UPDATES:
|
It seems the new |
I see. I'll go back to the former way. Thank you. |
0b94f5f
to
bd47c75
Compare
@akien-mga, sorry for the stream of updates. Since a showstopper for this PR was the lack of many implementations of With all the commits included here, this is fully aligned with master and should be ready to merge once #51173 and #51180 are validated. |
(cherry picked from commit 2dcd064)
bd47c75
to
c481174
Compare
Thanks! |
Version of #46270 + #51173 + #51180 for 3.x.