Allow overriding VERSION_STATUS with GODOT_VERSION_STATUS in env
#51002
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
enhancement
topic:buildsystem
cherrypick:3.x
`VERSION_STATUS` is part of what constitutes the reference version for a given Godot build, and is part of the version check for compatible export templates. For dev snapshots (alpha, beta, RCs), we usually set the `VERSION_STATUS` to a specific build number (e.g. `beta2`), but this change doesn't end up committed to the Git repository as we don't want to keep changing `version.py` for testing builds. So this new environment override will be what can be used in official builds and by users making custom builds for specific snapshots.
akien-mga
force-pushed
the
version-status-env-override
branch
from
adbfb09 to
948dcb6
Compare
|
Godot 4 Builds should use |
|
Examples from a test build on the official buildsystem with this and #51001:
|
akien-mga
added a commit
to godotengine/godot-build-scripts
that referenced
this pull request
Jul 29, 2021
Depends on godotengine/godot#51001 and godotengine/godot#51002, see the PRs for details.
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.3.3. |
akien-mga
added a commit
to godotengine/godot-build-scripts
that referenced
this pull request
Aug 3, 2021
Depends on godotengine/godot#51001 and godotengine/godot#51002, see the PRs for details. (cherry picked from commit f2e9922)
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Aug 19, 2021
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Sep 21, 2021
Follow-up to godotengine#51002. (cherry picked from commit 16f49d4)
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Sep 21, 2021
Follow-up to godotengine#51002. (cherry picked from commit 16f49d4)
sairam4123
pushed a commit
to sairam4123/godot
that referenced
this pull request
Nov 10, 2021
Follow-up to godotengine#51002. (cherry picked from commit 16f49d4)
lekoder
pushed a commit
to KoderaSoftwareUnlimited/godot
that referenced
this pull request
Dec 18, 2021
Follow-up to godotengine#51002. (cherry picked from commit 16f49d4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VERSION_STATUSis part of what constitutes the reference version for a givenGodot build, and is part of the version check for compatible export templates.
For dev snapshots (alpha, beta, RCs), we usually set the
VERSION_STATUStoa specific build number (e.g.
beta2), but this change doesn't end upcommitted to the Git repository as we don't want to keep changing
version.pyfor testing builds.
So this new environment override will be what can be used in official builds
and by users making custom builds for specific snapshots.
Together with #51001, this means that official builds can now be properly named
3.4.beta2.official.a71169c0e, and users have a guarantee that this build diduse a71169c without any custom changes. The only changes which make it special
are
BUILD_NAME=officialandGODOT_VERSION_STATUS=beta2, which users candefine themselves for custom builds (well, please don't use
BUILD_NAME=officialfor custom builds as it defeats its purpose ;)).
On the other hand, it means that the tarballs we distribute do not include e.g.
beta2inversion.py, and users must setGODOT_VERSION_STATUSif they wantto build a custom
beta2from that tarball.The "previous" workflow of directly editing
version.pyto set the values onewants is still possible of course.