[3.x] Backport KinematicBody move_and_slide and move_and_collide fixes #50495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Jul 17, 2021
Make sure the direction of the motion is preserved, unless the depth is higher than the margin, which means the body needs depenetration in any direction. Also changed move_and_slide to avoid sliding on the first motion, in order to avoid issues with unstable position on ground when jumping. Co-authored-by: fabriceci <fabricecipolla@gmail.com>
* Safe and unsafe motion are calculated by dichotomy with a limited number of steps. It's good for performance, but on long motions that either collide near the beginning or near the end, the result can be very imprecise. * Now a factor 0.25 or 0.75 is used to converge faster when this case happens, which allows longer motions to get more accurate collision detection. * Makes snap collision more precise, and helps with cases where diagonal collision on the border of a platform can lead to the character being stuck. Additional improvements to move_and_slide: * Handle slide canceling in move_and_collide with 0 velocity instead of not applying it. * Better handling of snap with custom logic to cancel sliding. * Remove small jittering when using stop on slope, by canceling the motion completely when the resulting motion is less than margin instead of always projecting to the up direction (in both body motion and snap). Co-authored-by: fabriceci <fabricecipolla@gmail.com>
pouleyKetchoupp
force-pushed
the
move-and-slide-fixes-3.x
branch
from
38fa5a7 to
beeebb4
Compare
|
@akien-mga Thanks, it's rebased. |
|
Thanks! |
|
Would it be possible to consider this for an update to |
|
Hi. I have a little platformer game. the player moves with move_and_slide_with_snap. it works fine with godot 3.3.3 and 3.3.2, but got problems with 3.4 b4. The problem is when the player is over a platform that moves from side to side, the platform moves, but the player do not. The platform is made with a tileset. The static body is made with the tileset to and moved with an animation player. Thanks |
|
@crapaam Hi! Please open an issue with a test project so someone can investigate the regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #49901 and #50063 to 3.x.
These two PRs together make both
move_and_collideandmove_and_slidemore reliable and after running a lot of tests (see original PRs for details) I'm confident they won't cause major regressions.Co-authored by @fabriceci
Supersedes #49902