Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Theme overriding existing theme types with empty #49308

Merged

Conversation

YuriSizov
Copy link
Contributor

These methods are only used in the theme editor, and are not exposed to the scripting API.

To reproduce the issue:

  1. Create an empty Theme resource.
  2. Click on "Manage Items" and add a new type.
  3. Create an arbitrary theme item for that type.
  4. Add the same type once again — added item will be deleted.

@YuriSizov YuriSizov added this to the 4.0 milestone Jun 4, 2021
@akien-mga akien-mga merged commit 0c7cb98 into godotengine:master Jun 7, 2021
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov deleted the theme-prevent-type-override branch June 7, 2021 11:30
YuriSizov added a commit to YuriSizov/godot that referenced this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants