Support multiple address resolution in DNS requests #49020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some comments:
|
|
This is the pull request from the original author: #12397 - it looks like it was "merged manually", by you. I'll update the commit message to be what it does and issue a new PR against master. |
|
Thanks for finding it, GitHub search had failed me. Looks like it was indeed fully reviewed and approved by @Faless, but my comment asking for a You can make a new PR for |
|
Looks like the only issue to master is the IP_Address -> IPAddress change. I'll have a new PR for master soon. |
sarchar
force-pushed
the
3.x
branch
2 times, most recently
from
09fb68d to
892d671
Compare
sarchar
force-pushed
the
3.x
branch
3 times, most recently
from
74bbc3a to
79a92bb
Compare
akien-mga
reviewed
Jun 8, 2021
akien-mga
reviewed
Jun 8, 2021
Add two new functions to the IP class that returns all addresses/aliases associated with a given address. This is a cherry-pick merge from 010a343 which was merged in 2.1, and has been updated to build with the latest code. This merge adds two new methods IP.resolve_hostname_addresses and IP.get_resolve_item_addresses that returns a List of all addresses returned from the DNS request.
akien-mga
approved these changes
Jun 9, 2021
akien-mga
changed the title
|
Thanks! |
Excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was previously merged into 2.1 as commit 010a343 but I don't see any build that actually was released with this change. The feature is extremely useful for certain network load balancing.
I've git cherry-pick'd and resolved the conflicts, and updated a few of the lines to make sure they work in 3.x.
Let me know if anything needs fixing.
Cheers