update meshoptimizer to version 0.16 #48002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should also update the commit message referenced here: https://github.com/godotengine/godot/blob/master/thirdparty/README.md#meshoptimizer |
|
Done :) |
akien-mga
reviewed
Apr 18, 2021
akien-mga
reviewed
Apr 18, 2021
|
Couple more nitpicks suggested, otherwise seems good 👍 Could you squash the commits into one? See PR workflow. |
Geometror
force-pushed
the
update-meshoptimizer
branch
from
c5b58c8 to
9d18610
Compare
|
Made the requested changes and squashed the commits into one |
|
You can merge to master and I can rebase. |
fire
approved these changes
Apr 18, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.