Fix macOS build with all sanitizers enabled. #47939
Conversation
|
Sanitizer messages on editor startup on macOS: godot/thirdparty/nanosvg/nanosvg.h Lines 2186 to 2190 in 0c8ec72 godot/servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.cpp Lines 2717 to 2719 in 0c8ec72 |
|
@bruvzg You're totally right about the leak detection I do think we should also consider that LLVM could be used on OSX directly: Apparently we can support leak detection if we use the LLVM/clang but not the one shipped from apple. Also docs states OSX support: I think we should fix it, I see there are linker problems. The manual says to use clang++ to do the linking portion too.
|
|
OK for the short term we will have to merge this patch regardless, I swapped to the clang linker but the issue persisted with the link process, even after following the manual. Also, I think the CI should have detected that these options are broken so I will follow up with a CI change to test we can compile ALL sanitisers, note: this won't mean they actually execute, just that they at least compile. In order to test the leak system I changed the section here see LINK this is not in our current setup we are using LD. else:
env["CC"] = "clang"
env["CXX"] = "clang++"
env["LINK"] = "clang++"The log for the linker error was as follows
|
platform/osx/detect.py
Outdated
| env.Append(CCFLAGS=["-fsanitize=bounds-strict"]) | ||
| env.Append( | ||
| CCFLAGS=[ | ||
| "-fsanitize=nullability-return,nullability-arg,function,nullability-assign,implicit-signed-integer-truncation,implicit-unsigned-integer-truncation" |
There was a problem hiding this comment.
Can you remove implicit-unsigned-integer-truncation and implicit-signed-integer-truncation from Linux, Mac and Server build?
I was almost sure that I removed that flags, but looks that they still exists here.
They cause error spam just like you show at the top:
thirdparty/misc/pcg.cpp:12:27: runtime error: implicit conversion from type 'unsigned long long' of value 111260437319 (64-bit, unsigned) to type 'uint32_t' (aka 'unsigned int') changed the value to 3886254919 (32-bit, unsigned)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior thirdparty/misc/pcg.cpp:12:27 in
core/variant/variant.cpp:2852:11: runtime error: implicit conversion from type 'int64_t' (aka 'long long') of value -1 (64-bit, signed) to type 'uint32_t' (aka 'unsigned int') changed the value to 4294967295 (32-bit, unsigned)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior core/variant/variant.cpp:2852:11 in
thirdparty/nanosvg/nanosvg.h:2190:49: runtime error: division by zero
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior thirdparty/nanosvg/nanosvg.h:2190:49 in
With this flags it is very hard to find real errors in code
There was a problem hiding this comment.
Can you remove implicit-unsigned-integer-truncation and implicit-signed-integer-truncation from Linux, Mac and Server build?
Done.
|
Thanks! |
Some sanitizer flag fixes for macOS (#40924 follow-up).
use_llvmenvironment variable, macOS build is LLVM only.-fsanitize=leakis not supported as standalone flag (it is integrated into address sanitizer, see: https://clang.llvm.org/docs/LeakSanitizer.html).-fsanitize=implicit-integer-sign-changeis not supported.Also removes
implicit-signed-integer-truncationandimplicit-unsigned-integer-truncation.