Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the About dialog to the project manager #47710

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Apr 7, 2021

The About button is located in the bottom-right corner of the project manager.

This allows removing the copyright notice from the window title (which looked a bit ugly in comparison to other applications).

It turns out EditorNode doesn't need to be referenced in EditorAbout for the theming overrides. With my changes, the dialog looks the same in the editor as it did before this PR.

Preview

image

@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor labels Apr 7, 2021
@Calinou Calinou added this to the 4.0 milestone Apr 7, 2021
@aaronfranke
Copy link
Member

Something weird happens to the top of the About page if I scroll a little bit:

Screenshot from 2021-04-07 22-02-04

@Calinou
Copy link
Member Author

Calinou commented Apr 8, 2021

Something weird happens to the top of the About page if I scroll a little bit:

This bug is unrelated to this PR, as it also happens in the editor's About dialog, not just in the project manager. It's present in master since the Complex Text Layouts update at least (if not before).

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To work with the macOS system menu (which always include "About" menu item), ProjectManager should handle NOTIFICATION_WM_ABOUT notification:

void ProjectManager::_notification(int p_what) {
	switch (p_what) {
...
		case NOTIFICATION_WM_ABOUT: {
			_show_about();
		} break;
...
	}
}

The About button is located in the bottom-right corner of the
project manager.

This allows removing the copyright notice from the window title
(which looked a bit ugly in comparison to other applications).
@Calinou Calinou force-pushed the project-manager-add-about-dialog branch from efb81da to 76722b5 Compare April 16, 2021 15:14
@akien-mga akien-mga merged commit 49511d4 into godotengine:master Apr 16, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Would need a dedicated PR to cherry-pick, it's too much bother cherry-picking changes to the project manager from 4.0 to 3.x.

@Calinou Calinou removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 1, 2021
@Calinou Calinou deleted the project-manager-add-about-dialog branch August 3, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants