-
-
Notifications
You must be signed in to change notification settings - Fork 22.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the About dialog to the project manager #47710
Add the About dialog to the project manager #47710
Conversation
This bug is unrelated to this PR, as it also happens in the editor's About dialog, not just in the project manager. It's present in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To work with the macOS system menu (which always include "About" menu item), ProjectManager
should handle NOTIFICATION_WM_ABOUT
notification:
void ProjectManager::_notification(int p_what) {
switch (p_what) {
...
case NOTIFICATION_WM_ABOUT: {
_show_about();
} break;
...
}
}
The About button is located in the bottom-right corner of the project manager. This allows removing the copyright notice from the window title (which looked a bit ugly in comparison to other applications).
efb81da
to
76722b5
Compare
Thanks! |
Would need a dedicated PR to cherry-pick, it's too much bother cherry-picking changes to the project manager from 4.0 to 3.x. |
The About button is located in the bottom-right corner of the project manager.
This allows removing the copyright notice from the window title (which looked a bit ugly in comparison to other applications).
It turns out EditorNode doesn't need to be referenced in EditorAbout for the theming overrides. With my changes, the dialog looks the same in the editor as it did before this PR.
Preview