[3.x] Android: Fix access to JavaVM for threads after #45618 #47682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- checking for validity of ENV in wrapper classes - fix for access to JavaVM from threads (cherry picked from commit b3a4343)
akien-mga
changed the title
hpvb
approved these changes
Apr 6, 2021
This was referenced Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit b3a4343)
Fixes #46832. Thanks @hpvb and @RandomShaper from identifying it.
Will test ASAP to confirm if it works. (CC @BastiaanOlij)
Edit: Tested and confirmed the fix 👍
Note that there are still unchecked
get_jni_env()calls in the codebase after this PR (both inmasterand3.2). Not sure if all should be guarded or ifget_jni_env()can be fixed to always give a valid pointer.