Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4588 (crash in Control::_set_anchor) #4612

Merged
merged 1 commit into from
May 11, 2016

Conversation

bojidar-bg
Copy link
Contributor

@vnen @her001 ~ You might want to test this PR 😄

@vnen
Copy link
Member

vnen commented May 11, 2016

Still segfaults in release mode, though it's not really related to your code. Gives me the same problem without this patch even after I revert 0e8a8d2 and bac875b. I'll try to bisect this.

(gdb) where
#0  0x0000000000594937 in DVector<String>::resize(int) ()
#1  0x00000000011fdd8c in ResourceInteractiveLoaderBinary::parse_variant(Variant&) ()
#2  0x00000000011fc669 in ResourceInteractiveLoaderBinary::parse_variant(Variant&) ()
#3  0x00000000011ff94b in ResourceInteractiveLoaderBinary::poll() ()
#4  0x000000000122692a in ResourceFormatLoader::load(String const&, String const&, Error*)
    ()
#5  0x00000000012260b9 in ResourceLoader::load(String const&, String const&, bool, Error*)
    ()
#6  0x0000000000429ff3 in Main::start() ()
#7  0x000000000040d0ed in main ()

@vnen
Copy link
Member

vnen commented May 11, 2016

Still getting segfault at 37af8b4. How come nobody ever got this bug? Or is it just me?

@akien-mga
Copy link
Member

@bojidar-bg Should we merge this patch as a general code quality improvement even if it doesn't fix #4588? (if so maybe you could amend the commit log, or alternatively I could do a "squash and merge" and rewrite the log).

@vnen
Copy link
Member

vnen commented May 11, 2016

@akien-mga technically, this does fix #4588. But it seems there's another bug with something else that gives segfaults in the GUI demos in release builds. Such bug seems not to be related to this patch or with this feature in general. I will open another issue about it.

@bojidar-bg
Copy link
Contributor Author

@akien-mga ~ well, feel free to rewrite and merge, though it probably does fix the issue (since master without that feature still segfaluts on release).

@akien-mga
Copy link
Member

Thanks, let's merge then.

@akien-mga akien-mga merged commit 7b47106 into godotengine:master May 11, 2016
@vnen
Copy link
Member

vnen commented May 11, 2016

Opened #4623 about the problem.

@bojidar-bg bojidar-bg deleted the fix-anchor-builds branch March 30, 2017 10:39
@aaronfranke aaronfranke added this to the 2.1 milestone Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants