Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore error flag to OpenSSL driver #4597

Merged
merged 1 commit into from
May 9, 2016
Merged

Add ignore error flag to OpenSSL driver #4597

merged 1 commit into from
May 9, 2016

Conversation

vnen
Copy link
Member

@vnen vnen commented May 9, 2016

This fixes #4517. However, it still doesn't build for Javascript with openssl=builtin because of another error:

ERROR: Linking globals named 'OPENSSL_cpuid_setup': symbol multiply defined!

@akien-mga
Copy link
Member

Looks like the same error message as #4560 fixed for opus.

@akien-mga akien-mga merged commit 7985bd8 into godotengine:master May 9, 2016
@akien-mga
Copy link
Member

I can confirm that it fixes the build for iOS, and that there is still an issue with Javascript: https://travis-ci.org/GodotBuilder/godot-builds/builds/128949407

However it breaks the build for MSVC as it doesn't support -W arguments: https://ci.appveyor.com/project/GodotBuilder/godot-builds/build/1.0.9

@vnen
Copy link
Member Author

vnen commented May 10, 2016

😠 Why it has to be so hard to make all compilers happy?

@vnen vnen deleted the pr-openssl-flag branch June 21, 2016 14:52
@aaronfranke aaronfranke added this to the 2.1 milestone Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement topic:buildsystem topic:thirdparty
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Can't build for iOS arm64 (builtin OpenSSL error)
3 participants
@vnen @akien-mga @aaronfranke