Added possibility to strip left and right to strip_edges #4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use len variable instead of calling length() every time.
* Accepts left for stripping on the left of the string * Accepts right for stripping on the right of the string
|
@mattiascibien ~ What about telling it which characters to strip (like python..)? E.g. I might want it to remove newlines, but leave spaces intact 😄 |
|
@bojidar-bg I wanted to wait for input on this as i think it is going to break compatibility |
|
@mattiascibien ~ You can always give it a sane default value, like |
|
@bojidar-bg I will have a look into it. The problem now is the order of parameters. The characters to be replaced should be the third one in my opinion as using it as the first will prevent doing things like |
akien-mga
pushed a commit
that referenced
this pull request
May 12, 2016
(cherry picked from commit 49c473b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two optional parameters to
strip_edgesin order to strip only left and only right part of the string. This are defaulted to true to ensure compatibility with current stripping mechanic.Also optimizes the call by replacing calls to
length()with a local variableFixes #968
If needed I can squish commits.