Improve nine patch behavior of TextureProgressBar #45815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
cherrypick:3.x
floppyhammer
requested review from
AndreaCatania,
bruvzg,
JFonS,
neikeq,
vnen and
a team
as code owners
floppyhammer
force-pushed
the
master
branch
4 times, most recently
from
66cddd8 to
f05e9b2
Compare
floppyhammer
changed the title
floppyhammer
force-pushed
the
master
branch
4 times, most recently
from
c6c9eac to
a2134fb
Compare
Calinou
requested changes
Mar 25, 2021
Calinou
approved these changes
Mar 26, 2021
|
@Calinou Sorry, messed things up when trying to rename the branch on Github. Can you reopen this? |
akien-mga
requested review from
a team
and removed request for
AndreaCatania,
bruvzg,
JFonS,
neikeq and
vnen
|
Could use a rebase to make sure that it still builds and runs fine on latest |
|
@akien-mga Done. |
akien-mga
approved these changes
Jun 21, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things related to
TextureProgressBarnode.Fixing TextureProgress's nine_patch_stretch property does not stretch textures for radial and bilinear fill_mode #45791. The fix enables basic texture stretch for radial fill mode when
nine_patch_stretchis enabled.->
Removing a redundant space character from the
CLOCKWISE_AND_COUNTER_CLOCKWISEentry inFill Mode.->
Fixing incorrect stretch of the progress texture for
RIGHT_TO_LEFTandBOTTOM_TO_TOPfill mode when asymmetric nine patch margins are applied.->
Implementing nine patch stretch for bilinear fill mode.
