Hardcode the export format for the editor 'run' feature #44638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
force-pushed
the
export_format_util_method
branch
from
a6c98df
to
ade49dd
Compare
RandomShaper
approved these changes
Dec 26, 2020
akien-mga
reviewed
Dec 27, 2020
m4gr3d
force-pushed
the
export_format_util_method
branch
from
ade49dd
to
de64b78
Compare
akien-mga
approved these changes
Dec 30, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
runfeature generates anapkfile that is automatically installed on the connected Android device. With the previous logic, switching the export format to Android app bundle (aab) for manual export would also negatively impact therunfeature: the logic would attempt to generate anaabfile instead of theapkfile needed by therunfeature hence causing an error.This PR resolves this issue by hardcoding the export format for the
runfeature.3.2 backport