Fixed Geometry2D::get_closest_points_between_segments docs #44317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Dec 12, 2020
mbrlabs
force-pushed
the
geometry2d-docs
branch
from
f8d24ce to
56e5ca3
Compare
akien-mga
added
cherrypick:3.x
akien-mga
approved these changes
Dec 12, 2020
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing unit tests for the Geometry2D class i thought i caught a bug in
Geometry2D::get_closest_points_between_segments, but actually it's just the documentation that's wrong.The segments are
(p1, q1),(p2, q2)not(p1, p2),(q1, q2).