Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the shortcut to close an open scene in the editor from CTRL+SHIFT+W to CTRL+W #44239

Closed
wants to merge 1 commit into from

Conversation

mbrlabs
Copy link
Contributor

@mbrlabs mbrlabs commented Dec 9, 2020

This is common shortcut and it's also used in Godot's script editor.
I'm not sure why the current shortcut is CTRL+SHIFT+W. Maybe there was a shortcut conflict in the past? If there are issues with this that i'm not aware of and it can't be worked around, i can close this again.

@Calinou
Copy link
Member

Calinou commented Dec 9, 2020

By default, Ctrl + W is used to close a script in the script editor:

image

We need to make sure the new shortcut for Close Scene doesn't conflict with Close Script. Maybe this is solved by the new shortcut handling in 4.0?

Tip: You can search shortcut values in the Editor Settings' Shortcuts tab, e.g. "Control+W".

@mbrlabs
Copy link
Contributor Author

mbrlabs commented Dec 9, 2020

Yeah, i tested this and there does not seem to be a conflict between closing scripts and scenes.

If you have a scene open and currently editing a script CTRL+W closes the scripts until all are closed. Then you can go to the 2D or 3D viewport and close the scene with the same shortcut. If you have scripts open and are in the 2D/3D viewport CTRL+W closes the scene as expected.

@aaronfranke
Copy link
Member

aaronfranke commented Dec 9, 2020

So this makes it impossible to close a scene with the shortcut if you're in the script editor? Maybe leave Ctrl+Shift+W bound too?

@mbrlabs
Copy link
Contributor Author

mbrlabs commented Dec 9, 2020

Well if there are no more scripts open the scene closes. But if you have scripts open and are in the script editor then yes...you can't close the scene. But this is what i would expect if you are in the script editor.

Yeah, i guess having two shortcuts would solve that. Let me try.

Edit: i don't think it's possible to have two shortcuts bound to the same action.

@EricEzaM
Copy link
Contributor

EricEzaM commented Dec 9, 2020

This was not possible before I think, not until until #42109 was merged. I think that before there would have been a conflict and both the scene and script would have closed.

No, you cannot have more than one input event bound to a shortcut.

Not sure if this is a good change. Probably wouldn't bother me but some people might not like it.

@mbrlabs
Copy link
Contributor Author

mbrlabs commented Dec 9, 2020

I think it would be more intuative/context-aware if the thing closes (scene or script) that is open using the same shortcut, but yeah...some people might not like that or prefer the current behaviour. It's tricky beacuse in Godot the script editor is opened in a scene tab.

But no big deal, i'm closing this then ;)

@mbrlabs mbrlabs closed this Dec 9, 2020
@KoBeWi KoBeWi added the archived label Dec 9, 2020
@Calinou Calinou removed this from the 4.0 milestone Dec 9, 2020
@mbrlabs mbrlabs deleted the close-shortcut branch December 9, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants