Add animation slices for individual animations #40274

Juankz · 2020-07-11T03:15:43Z

The clips method only worked if the imported model had an animation named "default". This PR allows clips to be created no matter what the one-track animation name is.

This closes my other PR #36709.

Bugsquad edit:

Closes Splitting animation clips on 3d model doesn't work. #25599.
Closes Godot 4 won't respect animation list #64486.

editor/import/resource_importer_scene.cpp

Juankz · 2020-07-11T15:37:23Z

I attach a sample project anim-clips.zip

noidexe · 2020-09-17T16:06:43Z

Is this merged on stable? Any ETAs?

akien-mga · 2020-09-17T19:47:42Z

Well this needs a review from @reduz who is more familiar with animation workflow.

For what it's worth, while I see value in allowing the use of other default animations than one named "default", I don't like that it arbitrarily picks the first one. It's a valid workflow to actually have an animation named "default", which may not be the first one, but which you want to be used as default.

noidexe · 2020-09-17T20:16:21Z

I don't like that it arbitrarily picks the first one.

Me neither but I've noticed more than one animator struggling with this and it seems that when using clips having one animation is the most common use case, while having it named "default" isn't, but rather the default named assigned by the 3dcg sofware.

The engine doesn't report any error when you try to clip with a different name, it just creates the wrong animations, so it becomes a RTFM moment for the integrator/animator.

If you a dozen of purchased assets it means re exporting every one of those which might even involve getting the software and learning how to do it in what would otherwise work by default.

I think a way it can work without breaking the workflow of those who are following the docs would be the following:

If there is an animation named 'default' use that for clipping
Otherwise use the first one as a fallback rather than failing

That would work well for people explicitly using "default" as well as for assets with only one animation with whatever name.

fire · 2021-08-25T00:24:56Z

The clips method only worked if the imported model had an animation named "default".

I can sense the usefulness of using the first track if it isn't named "default". However, the usage of "default" when there there are two tracks needs to be designed.

reduz · 2022-07-28T14:13:04Z

Is this still the case in 4.0?

Juankz · 2022-09-05T13:54:37Z

I haven't been able to use clips successfully in master branch with the test model I attached above. It keeps being imported as one animation track

YuriSizov · 2022-09-08T14:36:40Z

@godotengine/animation Can you confirm if this is still needed? And review, if it is :)

TokageItLab · 2022-09-08T14:45:17Z

I think it is good, but @fire is the best judge of this feature.

fire · 2022-09-08T15:31:27Z

Common workflow is to use one track and then split. Very wanted

YuriSizov · 2022-09-08T16:49:50Z

Right, then this needs a rebase and a review.

reduz · 2022-10-10T10:03:20Z

This makes sense, would be good to salvage.

Juankz · 2022-10-10T18:35:01Z

I'll take another look into it

This improves the workflow for animations in a single timeline. The users are no longer forced to slice one animation named "default". Instead users can choose which animation(s) to break and how. Changes: - Remove slicing options from the animation player import menu - Add such options to the animation import menu - Rename clips to slices wherever was left

Juankz · 2022-10-11T00:56:06Z

All right. Here's what I did:

Remove slicing options from the animation player import menu
Add such options to the animation import menu
Rename clips to slices wherever was left to be done. This was actually breaking the current workflow.

So the import menu looks like this.

Now instead of using "default" or picking arbitrarily the first one, the user can decide which animation to slice.

Here for example there are two timelines that needed slicing: One the body movement and another for facial animations. Such workflow is now possible with this PR.

Here is my demo project. Let me know what you think:
AnimationSlicesDemo.tar.gz

fire

40274-sample.mp4

The animation slice feature works like this:

for each animation ".anim" we have slices
You can set the slice to 0, the clips in the files or some number.
The point of this feature is for each "clip" you can remix the slices order and naming based on the frame count.
When the number is less, less clips are output
When the number is equal, there is no splitting
When it is more, clips are invented.
Might want to have a reset to default number of slices.

This is a feature review. Need to review the code.

fire · 2022-10-11T06:29:20Z

editor/import/resource_importer_scene.cpp

-		bool save_to_file = p_clips[i + 4];
-		String save_to_path = p_clips[i + 5];
-		bool keep_current = p_clips[i + 6];
+	for (int i = 0; i < p_slices.size(); i += 7) {


What does 7 mean, can you make it a named constant and the same with the ones below?

I didn't touch most of the slicing logic, I just updated the variable names. I see it's 7 because each slice contains 7 import options. But it was like that before. I can refactor it once I get some more free time. Also I would like to see if there are more comments on this PR.

akien-mga · 2022-10-11T14:19:55Z

Thanks! And congrats for your first merged Godot contribution 🎉

Juankz mentioned this pull request Jul 11, 2020

Implement animation clips for any animation name and multiple animations #36709

Closed

pouleyKetchoupp added enhancement topic:core topic:editor labels Jul 11, 2020

pouleyKetchoupp added this to the 4.0 milestone Jul 11, 2020

fire reviewed Jul 11, 2020

View reviewed changes

editor/import/resource_importer_scene.cpp Outdated Show resolved Hide resolved

Juankz force-pushed the clips_importing_improvement branch 2 times, most recently from 0343e19 to 824b668 Compare July 11, 2020 15:30

akien-mga requested a review from reduz July 14, 2020 07:54

aaronfranke added the topic:animation label Jan 20, 2021

YuriSizov requested a review from a team August 24, 2021 23:26

Calinou mentioned this pull request Dec 14, 2021

Splitting animation clips on 3d model doesn't work. #25599

Closed

Calinou added the topic:3d label Dec 14, 2021

fire mentioned this pull request Sep 11, 2022

"Fix Silhouette" in Retargeting does not work well on models other than A-pose or T-pose #65656

Closed

wenqiangwang mentioned this pull request Oct 3, 2022

Godot 4 won't respect animation list #64486

Closed

Juankz added 2 commits October 10, 2022 18:39

Connect signal animation_removed to its proper method

6e603f2

Juankz force-pushed the clips_importing_improvement branch from 824b668 to 8ad3f8f Compare October 10, 2022 23:55

Juankz requested a review from a team as a code owner October 10, 2022 23:55

Juankz changed the title ~~Replace "default" for any animation name when importing clips~~ Add animation slices for individual animations Oct 11, 2022

fire approved these changes Oct 11, 2022

View reviewed changes

fire reviewed Oct 11, 2022

View reviewed changes

akien-mga approved these changes Oct 11, 2022

View reviewed changes

akien-mga merged commit 042e81f into godotengine:master Oct 11, 2022

jtnicholl mentioned this pull request Nov 20, 2022

glTF .import files include slice information for 256 slices, if any animation options are set #68936

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add animation slices for individual animations #40274

Add animation slices for individual animations #40274

Juankz commented Jul 11, 2020 •

edited by akien-mga

Loading

Juankz commented Jul 11, 2020

noidexe commented Sep 17, 2020

akien-mga commented Sep 17, 2020

noidexe commented Sep 17, 2020 •

edited

Loading

fire commented Aug 25, 2021

reduz commented Jul 28, 2022

Juankz commented Sep 5, 2022

YuriSizov commented Sep 8, 2022 •

edited

Loading

TokageItLab commented Sep 8, 2022

fire commented Sep 8, 2022

YuriSizov commented Sep 8, 2022

reduz commented Oct 10, 2022

Juankz commented Oct 10, 2022

Juankz commented Oct 11, 2022

fire left a comment •

edited

Loading

fire Oct 11, 2022

Juankz Oct 11, 2022

akien-mga commented Oct 11, 2022 •

edited

Loading

Add animation slices for individual animations #40274

Add animation slices for individual animations #40274

Conversation

Juankz commented Jul 11, 2020 • edited by akien-mga Loading

Juankz commented Jul 11, 2020

noidexe commented Sep 17, 2020

akien-mga commented Sep 17, 2020

noidexe commented Sep 17, 2020 • edited Loading

fire commented Aug 25, 2021

reduz commented Jul 28, 2022

Juankz commented Sep 5, 2022

YuriSizov commented Sep 8, 2022 • edited Loading

TokageItLab commented Sep 8, 2022

fire commented Sep 8, 2022

YuriSizov commented Sep 8, 2022

reduz commented Oct 10, 2022

Juankz commented Oct 10, 2022

Juankz commented Oct 11, 2022

fire left a comment • edited Loading

Choose a reason for hiding this comment

fire Oct 11, 2022

Choose a reason for hiding this comment

Juankz Oct 11, 2022

Choose a reason for hiding this comment

akien-mga commented Oct 11, 2022 • edited Loading

Juankz commented Jul 11, 2020 •

edited by akien-mga

Loading

noidexe commented Sep 17, 2020 •

edited

Loading

YuriSizov commented Sep 8, 2022 •

edited

Loading

fire left a comment •

edited

Loading

akien-mga commented Oct 11, 2022 •

edited

Loading