Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "ParentNode" to "Inherit" in Texture Options #39544

Merged

Conversation

nathanfranke
Copy link
Contributor

I mentioned this here but opening a PR to make sure it is remembered.

While this PR is open we can discuss possible name changes to the other options in this dropdown.

@akien-mga akien-mga added this to the 4.0 milestone Jun 15, 2020
@akien-mga akien-mga merged commit e606b51 into godotengine:master Jun 15, 2020
@akien-mga
Copy link
Member

Thanks!

@nathanfranke nathanfranke deleted the canvas-item-parent-node-rename branch June 15, 2020 22:13
@nathanfranke
Copy link
Contributor Author

This was merged already but should we change any of these names or add tooltips? I still don't understand what difference they make.

  • Nearest
  • Linear
  • MipmapNearest
  • MipmapLinear
  • MipmapNearestAniso
  • MipmapLinearAniso

@akien-mga
Copy link
Member

I would suggest writing documentation for them, and then we can see if they could use a better name. I think the PascalCase naming and abbreviation for Anisotropic is not necessarily useful, so those names could be "Mipmap Nearest", "Mipmap Linear Anisotropic", etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants