Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved ctrl + alt + special character Issue #6851 #37769

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

HellonLegs
Copy link
Contributor

@HellonLegs HellonLegs commented Apr 10, 2020

Fixes #6851

If ctrl was pressed the unicode got ignored.
To solve this I added an additional condition to the If statement.

I may have missed some files that also need to be changed

Bugsquad edit: This closes #29399.

@akien-mga akien-mga added this to the 4.0 milestone Apr 10, 2020
@akien-mga akien-mga requested a review from Paulb23 April 10, 2020 19:15
@HellonLegs HellonLegs closed this Apr 25, 2020
@HellonLegs HellonLegs reopened this Apr 25, 2020
@Calinou Calinou added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 25, 2020
Copy link
Member

@Paulb23 Paulb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks okay, though haven't tested it on windows.

@akien-mga akien-mga merged commit 044b3d0 into godotengine:master Aug 14, 2020
@akien-mga
Copy link
Member

Thanks!

@Calinou
Copy link
Member

Calinou commented Aug 23, 2020

@akien-mga Can this be cherry-picked to the 3.2 branch before 3.2.3 is released, or is this considered too risky?

@akien-mga
Copy link
Member

Too risky.

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants