Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all gizmo classes, using the 4.0 node names. #37644

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Rename all gizmo classes, using the 4.0 node names. #37644

merged 1 commit into from
Apr 8, 2020

Conversation

JFonS
Copy link
Contributor

@JFonS JFonS commented Apr 6, 2020

No description provided.

@JFonS JFonS added this to the 4.0 milestone Apr 6, 2020
@JFonS JFonS requested a review from BastiaanOlij as a code owner April 6, 2020 21:55
@akien-mga
Copy link
Member

akien-mga commented Apr 7, 2020 •
edited
Loading

There are also this one:

  • PathNode3DGizmo --> Path3DGizmo // should already have been Path3DNode3DGizmo but it was missed in earlier renames

It seems to be the only class that extends EditorNode3DGizmo.

@JFonS
Copy link
Contributor Author

JFonS commented Apr 7, 2020

@akien-mga fixed.

@akien-mga akien-mga merged commit d89dc57 into godotengine:master Apr 8, 2020
@akien-mga
Copy link
Member

Thanks!

@JFonS JFonS deleted the gizmos_rename branch May 4, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@BastiaanOlij BastiaanOlij Awaiting requested review from BastiaanOlij

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JFonS @akien-mga