Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable NetSocket reuse address on Windows. #36321

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Feb 18, 2020

It actually means reuse port -.- ...

See https://docs.microsoft.com/en-us/windows/win32/winsock/so-exclusiveaddruse .

Potentially fixes #35350 . Needs testing.

It actually means reuse port -.- ...
@zaksnet
Copy link
Contributor

zaksnet commented Feb 18, 2020

It actually means reuse port -.- ...

See https://docs.microsoft.com/en-us/windows/win32/winsock/so-exclusiveaddruse .

Potentially fixes #35350 . Needs testing.

Indeed this fixes #35350 🎉
image

@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 18, 2020
@akien-mga akien-mga merged commit 6e64036 into godotengine:master Feb 18, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.1. (Together with #36349.)

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tcp_server checking if port is free fails in windows
3 participants