Skip to content

Remove useless pluginscript godot_pluginscript_script_desc.get_rpc/rset_mode fields #35811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2020
Merged

Remove useless pluginscript godot_pluginscript_script_desc.get_rpc/rset_mode fields #35811

merged 1 commit into from
Feb 1, 2020

Conversation

touilleMan
Copy link
Member

@touilleMan touilleMan commented Feb 1, 2020 •
edited
Loading

breaking change in Pluginscript api for Godot 4.0

@touilleMan touilleMan mentioned this pull request Feb 1, 2020
Closed
@clayjohn clayjohn added this to the 4.0 milestone Feb 1, 2020
@clayjohn
Copy link
Member

clayjohn commented Feb 1, 2020

Could you please provide a description of what the change does and why? For future reference.

@touilleMan
Copy link
Member Author

The two fields get_rpc and rset_mode in the godot_pluginscript_script_desc were never used internally so they could be safely removed. However this change the structure of godot_pluginscript_script_desc so it is a breaking change for any 3rd party using pluginscript (like Godot-Python for instance)

@akien-mga akien-mga merged commit 739f583 into godotengine:master Feb 1, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement topic:gdextension
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@touilleMan @clayjohn @akien-mga