Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Camera preview when creating new scenes #33491

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Fixed Camera preview when creating new scenes #33491

merged 1 commit into from
Nov 9, 2019

Conversation

pouleyKetchoupp
Copy link
Contributor

The Camera preview button wasn't connected properly when a new viewport was created, unless a scene was loaded.
Same thing when switching from a loaded scene to a scene which is not saved yet, the preview button wasn't properly reconnected.

Fixes #33490

@akien-mga akien-mga added this to the 3.2 milestone Nov 9, 2019
@akien-mga
Copy link
Member

The regression was caused by #33107 which this partially reverts, so it would be good to check that #29230 is not reintroduced. CC @volzhs

@pouleyKetchoupp
Copy link
Contributor Author

I've tried and didn't reproduce the error cases from #29230 or #33050 with the new changes.

@akien-mga akien-mga merged commit 78f7cca into godotengine:master Nov 9, 2019
@akien-mga
Copy link
Member

Thanks!

@pouleyKetchoupp pouleyKetchoupp deleted the camera-preview-new-scene branch November 9, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Camera Preview doesn't work on a new scene in an empty project
3 participants
@pouleyKetchoupp @akien-mga @Calinou