Improve performance of connection info in the script editor #33105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully resolved most of the performance issues with the connection info in the script editor.
The majority of the time was spent in
get_language()->find_function
as it parses the script line by line for the function. Changing this tohas_method / get_member_line
improves performance as it uses the preparsed script, however, it will now require a valid script for it to work.It now keeps a
Set
of methods that already have a connection, saving having to search for it again.Lastly, swapped checking for a valid texture resource and string for a plain bool.
should close #32236