Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of connection info in the script editor #33105

Merged

Conversation

Paulb23
Copy link
Member

@Paulb23 Paulb23 commented Oct 27, 2019

Hopefully resolved most of the performance issues with the connection info in the script editor.

The majority of the time was spent in get_language()->find_function as it parses the script line by line for the function. Changing this to has_method / get_member_line improves performance as it uses the preparsed script, however, it will now require a valid script for it to work.

It now keeps a Set of methods that already have a connection, saving having to search for it again.

Lastly, swapped checking for a valid texture resource and string for a plain bool.

should close #32236

@Paulb23 Paulb23 added this to the 3.2 milestone Oct 27, 2019
@akien-mga akien-mga merged commit 77075c2 into godotengine:master Oct 27, 2019
@akien-mga
Copy link
Member

Thanks!

@Paulb23 Paulb23 deleted the issue_32236_script_conection_performance branch October 27, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code scrolling and Editor slow on huge files due to connection information
2 participants